[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Add code for early tcss

[Brandon Breitenstein (Code Review)]

Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42079 )

Change subject: soc/intel/tigerlake: Add code for early tcss
......................................................................

Patch Set 22:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42079/22/src/soc/intel/tigerlake/ea... 
File src/soc/intel/tigerlake/early_tcss.c:

https://review.coreboot.org/c/coreboot/+/42079/22/src/soc/intel/tigerlake/ea... 
PS22, Line 144: 	cmd = tcss_make_safe_mode_cmd(
              : 		PMC_IPC_TCSS_SAFE_MODE_REQ_RES,
              : 		mux_data.usb3_port);
> I think this will all fit on 1 line

I think it was just long but I will at least move PMC_IPC variable up a line

https://review.coreboot.org/c/coreboot/+/42079/22/src/soc/intel/tigerlake/ea... 
PS22, Line 179: 	static uint8_t hpd_lvl;
> Shouldn't this be a per-port HPD, since the state is stored across calls?

I'm going to remove this completely with the new MUX spec the hpd call is required for every dp mode not only when hpd changes