Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48801 )
Change subject: mb/clevo/cml-u: move gpio early init to bootblock_mainboard_early_init ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48801/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48801/2//COMMIT_MSG@10 PS2, Line 10: after gpio configuration in : common code got dropped.
As soon ("after") the common code got dropped, the pads will be configured by mainboard code, which runs later. This patch makes it being initialized again earlier.
Well. I understand now what you are trying to say, but this is irritating and wrong, I think, because:
* You assume that the common GPIO code is going to be dropped, which we don't know, because it is not happened yet.
* If the common GPIO code doesn't get dropped, bootblock_soc_early_init() runs earlier and it also configures the UART pads. Also, this doesn't represent the current state of master.