Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43604 )
Change subject: lib: Add ASan support to romstage on x86 arch ......................................................................
Patch Set 9: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/43604/9/src/lib/asan.c File src/lib/asan.c:
https://review.coreboot.org/c/coreboot/+/43604/9/src/lib/asan.c@27 PS9, Line 27: #else This else means that every other stage beside romstage (not just the ramstage but verstage, bootblock, ...) will use this path. I somehow would more like to have an #elif ENV_RAMSTAGE here instead to make sure that this will only be valid for the ramstage as you use linker symbols from the ramstage here.
https://review.coreboot.org/c/coreboot/+/43604/9/src/lib/asan.c@38 PS9, Line 38: #else Same here.
https://review.coreboot.org/c/coreboot/+/43604/9/src/lib/asan.c@249 PS9, Line 249: #else And here.
https://review.coreboot.org/c/coreboot/+/43604/9/src/lib/asan.c@280 PS9, Line 280: #else And here.
https://review.coreboot.org/c/coreboot/+/43604/9/src/lib/asan.c@334 PS9, Line 334: #else And here.