[coreboot-gerrit] [XS] Change in coreboot[main]: mb/google/brox: Fix configuration for TPM in Kconfig

[Shelley Chen (Code Review)]

Attention is currently required from: Eric Lai, Ivy Jian, Nick Vaccaro, Paul Menzel.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79102?usp=email )

Change subject: mb/google/brox: Fix configuration for TPM in Kconfig
......................................................................

Patch Set 2:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/79102/comment/d49928c7_feba9572 :
PS1, Line 7: Fix configuration for TPM in Kconfig
> If possible, please be more specific.

Acknowledged.  Added description.

https://review.coreboot.org/c/coreboot/+/79102/comment/7335ef60_77d8b093 :
PS1, Line 7: Fix configuration for TPM in Kconfig
> nit:mb/google/brox:

Done

https://review.coreboot.org/c/coreboot/+/79102/comment/19aa1a33_6377c0a4 :
PS1, Line 8:
> Please elaborate.

Done

File src/mainboard/google/brox/Kconfig:

https://review.coreboot.org/c/coreboot/+/79102/comment/d90f7d74_291a5fd4 :
PS1, Line 90: 33
> Hi Nick,  […]

Done

https://review.coreboot.org/c/coreboot/+/79102/comment/c547d2e6_a2da8ca1 :
PS1, Line 90: 	default 33 # GPE0_DW1_01 (GPP_D01)
> should it be 66 #GPE0_DW2_02 (GPP_E2)? I see GPP_E2 for GSC_PCH_INT_ODL in gpio. […]

You are 100% correct.  Thanks for catching this.