Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44974 )
Change subject: soc/intel/xeon_sp/cpx: display FSP_PREV_BOOT_ERR_SRC_HOB
......................................................................
Patch Set 3:
(1 comment)
The hob printing might be a little more readable as a switch statement.
https://review.coreboot.org/c/coreboot/+/44974/3/src/soc/intel/xeon_sp/cpx/h...
File src/soc/intel/xeon_sp/cpx/hob_display.c:
https://review.coreboot.org/c/coreboot/+/44974/3/src/soc/intel/xeon_sp/cpx/h...
PS3, Line 193: if
This would read a little better as a switch/case statement.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44974
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idbace4c2500440b3c1cf2628dd921ca1a989ae81
Gerrit-Change-Number: 44974
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Sep 2020 22:14:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment