Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46432 )
Change subject: security/vboot: Make mrc_cache hash functions generic ......................................................................
Patch Set 16: Code-Review+1
(4 comments)
`
https://review.coreboot.org/c/coreboot/+/46432/16/src/security/vboot/antirol... File src/security/vboot/antirollback.h:
https://review.coreboot.org/c/coreboot/+/46432/16/src/security/vboot/antirol... PS16, Line 62: data from which hash is to be computed That is not correct. This is a pointer to a data buffer where the hash from TPM is read into.
https://review.coreboot.org/c/coreboot/+/46432/16/src/security/vboot/antirol... PS16, Line 63: size of data from which has is to be computed size of the data buffer where the hash from TPM is read into.
https://review.coreboot.org/c/coreboot/+/46432/16/src/security/vboot/antirol... PS16, Line 69: data from which hash is to be computed Same comment as above.
https://review.coreboot.org/c/coreboot/+/46432/16/src/security/vboot/antirol... PS16, Line 70: size of data from which has is to be computed Same here.