Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45219 )
Change subject: xeon_sp/cpx/: Remove duplicate defines in pci_devs.h
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45219/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45219/2//COMMIT_MSG@7
PS2, Line 7: xeon_sp/cpx/: Remove duplicate defines in pci_devs.h
veeery minor nit: I'd put the file name in the prefix:
xeon_sp/cpx/pci_devs.h: Remove duplicate defines
I don't mind either approach, though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45219
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fc4e07269175eb2f40655b828e340697a9a892a
Gerrit-Change-Number: 45219
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Sep 2020 09:25:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment