build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38359 )
Change subject: nb/intel/nehalem: Try to clean up code ......................................................................
Patch Set 6:
(16 comments)
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... File src/northbridge/intel/nehalem/raminit.c:
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 73: #define FOR_CHAN_RANKS FOR_EACH_SLOT FOR_EACH_RANK Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 74: #define FOR_CHAN_LANES(ecc) FOR_CHAN_RANKS FOR_EACH_LANE(ecc) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 75: #define FOR_ALL_RANKS FOR_EACH_CHANNEL_UP FOR_CHAN_RANKS Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 76: #define FOR_ALL_RANKS_DOWN FOR_EACH_CHANNEL_DN FOR_CHAN_RANKS Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 77: #define FOR_ALL_SLOTS FOR_EACH_CHANNEL_UP FOR_EACH_SLOT Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 78: #define FOR_ALL_LANES(ecc) FOR_ALL_RANKS FOR_EACH_LANE(ecc) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 80: #define IF_POPULATED if (info->populated_ranks[channel][slot][rank]) Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 81: #define FOR_POPULATED_RANKS FOR_ALL_RANKS IF_POPULATED Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 82: #define FOR_POPULATED_RANKS_DOWN FOR_ALL_RANKS_DOWN IF_POPULATED Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 83: #define FOR_POPULATED_CHAN_RANKS FOR_CHAN_RANKS IF_POPULATED Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 85: #define FOR_POPULATED_LANES(ecc) FOR_POPULATED_RANKS FOR_EACH_LANE(ecc) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 86: #define FOR_POPULATED_LANES_DOWN(ecc) FOR_POPULATED_RANKS_DOWN FOR_EACH_LANE(ecc) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 87: #define FOR_POPULATED_CHAN_LANES(ecc) FOR_POPULATED_CHAN_RANKS FOR_EACH_LANE(ecc) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 2336: if (timings[reg_178][channel][slot][rank] Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 2342: } else { Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/38359/6/src/northbridge/intel/nehal... PS6, Line 2415: if (timings[reg_178][channel][slot][rank] Too many leading tabs - consider code refactoring