[coreboot-gerrit] Change in ...coreboot[master]: device/root_device: Consolidate common _scan_bus() functions

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31901 )

Change subject: device/root_device: Consolidate common _scan_bus() functions
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31901/1/src/device/root_device.c 
File src/device/root_device.c:

https://review.coreboot.org/#/c/31901/1/src/device/root_device.c@115 
PS1, Line 115: 	printk(BIOS_SPEW, "%s for %s\n", __func__, dev_path(bus));
> Is that what you have in mind / would work:

No, the other way around.

void scan_static_bus(struct device *bus, const char *realname)
     {
             printk(..., "%s...", realname, ...);
             ...
     }

void root_dev_scan_bus(struct device *bus)
     {
             scan_static_bus(bus, __func__);
     }

void scan_usb_bus(struct device *bus)
     {
             scan_static_bus(bus, __func__);
     }

They way they are called made me realise the wrappers would not inline.