[coreboot-gerrit] Change in coreboot[master]: drivers/amd/agesa: Drop redundant stack allocation

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33956 )

Change subject: drivers/amd/agesa: Drop redundant stack allocation
......................................................................

Patch Set 2:
> Patch Set 2: Code-Review+1
>
> AGESA resume from S3 still works with G505S with this. Although - if combined with a new "CONFIG_SECURITY_CLEAR_DRAM_ON_REGULAR_BOOT" - S3 stops working (haven't tested this config alone yet).
> > Always clear the DRAM after DRAM initialization regardless of additional security implementations in use.
>
> This increases boot time depending on the amount of DRAM installed.

AGESA has valuables in low memory and coreboot does not really keep account of them. I think it's BIOS_HEAP_START_ADDRESS + _SIZE you are not allowed to clear. So I expect S3 resume with that CLEAR_DRAM feature enabled to fail regardless of this commit.