Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37787 )
Change subject: security/vboot: Add a dedicated flag for building of vboot library
......................................................................
Patch Set 8:
(1 comment)
Patch Set 7:
(3 comments)
Another naming option would be to use:
VBOOT (or VBOOT_LIB) - include the vboot library functions
VBOOT_VERIFY_FIRMWARE - enable firmware verification
What do you think?
I would rather keep the VBOOT flag, for I don't know how to efficiently and correctly change hundreds of its appearance around the whole coreboot tree.
Check out the `sed` utility.
But how to match and replace "VBOOT" without touching "*_VBOOT_*"?
https://review.coreboot.org/c/coreboot/+/37787/7/src/security/vboot/Kconfig
File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/37787/7/src/security/vboot/Kconfig@...
PS7, Line 22: Building and linking the vboot library.
How about just "Build and link the vboot library. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1907a11c851ee45a70582e02bdbe08fb18cc6a4
Gerrit-Change-Number: 37787
Gerrit-PatchSet: 8
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Dec 2019 10:53:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Gerrit-MessageType: comment