Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Angel Pons.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/ocp/deltalake/vpd.h:
https://review.coreboot.org/c/coreboot/+/47006/comment/d763ecb1_4ec541a7
PS3, Line 36: /* SMM log level */
What are the possible values? Let's document here.
Should we check to make sure the value is legitimate before passing it to SMM?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47006
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c
Gerrit-Change-Number: 47006
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 15 Jan 2021 03:31:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment