Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: google/kukui: force run dram full-k blob ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35110/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35110/1//COMMIT_MSG@7 PS1, Line 7: full-k What is full-k?
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 46: printk(BIOS_ERR, "dram.bin after _dram_init_code\n"); Please rephrase to be understandable to a user.
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 74: printk(BIOS_INFO, "dram_blob load success\n"); Successfully loaded and run DRAM initialization blob.
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 80: //load params from sdram-ddr-config Please add a space after `//`.