Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31086 )
Change subject: payloads/ipxe: Enable HTTPS support
......................................................................
Patch Set 7: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/31086/6/payloads/external/iPXE/Kcon...
File payloads/external/iPXE/Kconfig:
https://review.coreboot.org/c/coreboot/+/31086/6/payloads/external/iPXE/Kcon...
PS6, Line 118: default n
Any reason for 'n' here? Are we worried about size of binary?
Ack
https://review.coreboot.org/c/coreboot/+/31086/6/payloads/external/iPXE/Make...
File payloads/external/iPXE/Makefile:
https://review.coreboot.org/c/coreboot/+/31086/6/payloads/external/iPXE/Make...
PS6, Line 70: ifeq ($(CONFIG_PXE_HAS_HTTPS),y)
Inconsistent spacing above this and preceding 'if(n)eq's
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia25d4ce9260fa8c00fdea0e19f5e927559371af0
Gerrit-Change-Number: 31086
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 Apr 2020 11:09:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-MessageType: comment
