Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop loading changes ......................................................................
Patch Set 33:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/05076cb7_5a0690d9 PS33, Line 11: bool aop_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/94d84cbc_d0b8632a PS33, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/8e080467_fc86dace PS33, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/bf42544c_cfeb804a PS33, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/eb95fc9e_bc2e6d79 PS33, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/eefc9aae_a34858cd PS33, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/5b74ddfc_b8cea067 PS33, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/f46bef29_9568d376 PS33, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/2d5c08f5_7939206a PS33, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/984cee08_fa47b669 PS33, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/0e19eebc_3c62ecd3 PS33, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/d3c8ff98_22c74e8d PS33, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/4e2905a6_cdbea112 PS33, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/e219fd55_aea85e73 PS33, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/2625271c_ad7c1dd1 PS33, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/3243da1c_98901804 PS33, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/a3b247e2_e93fd75d PS33, Line 23: clock_reset_aop(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/d964b1ca_4cd42dc1 PS33, Line 23: clock_reset_aop(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/f2d931d4_a6059cb5 PS33, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/e8a3fe4e_96d6cb73 PS33, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/0f216f78_58e18732 PS33, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/0f5a4452_037010a0 PS33, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/47c2b8d0_d9c6fc6e PS33, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/9202e54c_0b2bc661 PS33, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/9f144f52_1364bf1a PS33, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118670): https://review.coreboot.org/c/coreboot/+/49767/comment/ff49964c_58d161dd PS33, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line