Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56093 )
Change subject: mb/google/herobrine: Initialize USB by calling SOC method ......................................................................
Patch Set 37:
(3 comments)
File src/mainboard/google/herobrine/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133271): https://review.coreboot.org/c/coreboot/+/56093/comment/90194833_826c954d PS37, Line 19: .parameter_override_x0 = 0xe6, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133271): https://review.coreboot.org/c/coreboot/+/56093/comment/6d7a034d_12f03283 PS37, Line 20: .parameter_override_x1 = 0x8b, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133271): https://review.coreboot.org/c/coreboot/+/56093/comment/ef913def_07ca512b PS37, Line 21: .parameter_override_x2 = 0x16, please, no spaces at the start of a line