build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40731 )
Change subject: mb/ocp/tiogapass: rework GPIOs configuration using macros ......................................................................
Patch Set 5:
(10 comments)
https://review.coreboot.org/c/coreboot/+/40731/5/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/gpio.h:
https://review.coreboot.org/c/coreboot/+/40731/5/src/mainboard/ocp/tiogapass... PS5, Line 123: _PAD_CFG_STRUCT(GPP_F5, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(TX_DISABLE) | 1, PAD_CFG_OWN_GPIO(DRIVER) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40731/5/src/mainboard/ocp/tiogapass... PS5, Line 178: _PAD_CFG_STRUCT(GPP_C10, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_CFG0_TRIG_EDGE_BOTH | PAD_CFG0_RX_POL_NONE | PAD_BUF(TX_DISABLE) | 1, PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40731/5/src/mainboard/ocp/tiogapass... PS5, Line 182: _PAD_CFG_STRUCT(GPP_C12, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(TX_DISABLE) | 1, PAD_CFG_OWN_GPIO(DRIVER) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40731/5/src/mainboard/ocp/tiogapass... PS5, Line 184: _PAD_CFG_STRUCT(GPP_C13, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(TX_DISABLE) | 1, PAD_CFG_OWN_GPIO(DRIVER) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40731/5/src/mainboard/ocp/tiogapass... PS5, Line 299: _PAD_CFG_STRUCT(GPD7, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(TX_DISABLE) | 1, PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40731/5/src/mainboard/ocp/tiogapass... PS5, Line 436: _PAD_CFG_STRUCT(GPP_G12, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(TX_DISABLE) | 1, PAD_CFG_OWN_GPIO(DRIVER) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40731/5/src/mainboard/ocp/tiogapass... PS5, Line 438: _PAD_CFG_STRUCT(GPP_G13, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(TX_DISABLE) | 1, PAD_CFG_OWN_GPIO(DRIVER) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40731/5/src/mainboard/ocp/tiogapass... PS5, Line 440: _PAD_CFG_STRUCT(GPP_G14, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(TX_DISABLE) | 1, PAD_CFG_OWN_GPIO(DRIVER) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40731/5/src/mainboard/ocp/tiogapass... PS5, Line 442: _PAD_CFG_STRUCT(GPP_G15, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(TX_DISABLE) | 1, PAD_CFG_OWN_GPIO(DRIVER) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40731/5/src/mainboard/ocp/tiogapass... PS5, Line 444: _PAD_CFG_STRUCT(GPP_G16, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(TX_DISABLE) | 1, PAD_CFG_OWN_GPIO(DRIVER) | PAD_PULL(NONE)), line over 96 characters