Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34333 )
Change subject: arch/x86/acpi.c: Change TPM2 ACPI Table to support CRB ......................................................................
Patch Set 22:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34333/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34333/7//COMMIT_MSG@9 PS7, Line 9: Change the TPM2 ACPI Table to support CRB Interface when : selected.
Should fit on one line?
Ack
https://review.coreboot.org/c/coreboot/+/34333/22//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34333/22//COMMIT_MSG@7 PS22, Line 7: Change
Redundant, as a commit often changes something. […]
True - but I guess there is a difference if you CHANGE a functionality, or add/remove it. So to be clear - i"ll keep it there.
https://review.coreboot.org/c/coreboot/+/34333/22//COMMIT_MSG@7 PS22, Line 7: src/arch/x86/acpi.c: Change TPM2 ACPI Table to support CRB
Please remove `src`.
Ack
https://review.coreboot.org/c/coreboot/+/34333/22//COMMIT_MSG@10 PS22, Line 10: selected.
Sentence should fit on one line.
Ack
https://review.coreboot.org/c/coreboot/+/34333/20/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/c/coreboot/+/34333/20/src/arch/x86/acpi.c@391 PS20, Line 391: tpm2->control_area = 0xfed40040;
CONFIG_CRB_TPM_BASE_ADDRESS + 0x40
Ack