Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Rishika Raj.
Subrata Banik has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/83720?usp=email )
Change subject: mb/google/nissa/var/riven: Disable CNVi WIFI and BT based on fw_config
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/riven/fw_config.c:
https://review.coreboot.org/c/coreboot/+/83720/comment/05c6e7d6_cce1b173?usp... :
PS1, Line 70: if (!fw_config_probe(FW_CONFIG(WIFI_TYPE, WIFI_CNVI))) {
should we check
```
if (!fw_config_is_provisioned()) {
printk(BIOS_WARNING, "FW_CONFIG is not provisioned. Exiting...\n");
return;
}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83720?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icb925c02c73d3630be8b78debf608270b08854fe
Gerrit-Change-Number: 83720
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 01 Aug 2024 09:10:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No