Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41075 )
Change subject: soc/amd/picasso: Enable eSPI capability for Picasso
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41075/11/src/soc/amd/picasso/southb...
File src/soc/amd/picasso/southbridge.c:
https://review.coreboot.org/c/coreboot/+/41075/11/src/soc/amd/picasso/southb...
PS11, Line 210: PICASSO_LPC_IOMUX
ok, it's probably not exactly this place, but I'm still rather sure that the breakage occurred somew […]
I see Mandolin selecting SOC_AMD_COMMON_BLOCK_USE_ESPI. So, I don't think lpc_configure_decodes() would ever get called with that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4876f1bff4305a23e8ccc48a2d0d3b64cdc9703d
Gerrit-Change-Number: 41075
Gerrit-PatchSet: 11
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Jun 2020 23:42:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment