Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39427 )
Change subject: mb/ocp/tiogapass: use common GPIO config ......................................................................
Patch Set 14:
(3 comments)
Thanks for the review
https://review.coreboot.org/c/coreboot/+/39427/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39427/5//COMMIT_MSG@8 PS5, Line 8:
Done?
Done
https://review.coreboot.org/c/coreboot/+/39427/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39427/12//COMMIT_MSG@10 PS12, Line 10: inte
inte*L*
Done
https://review.coreboot.org/c/coreboot/+/39427/13/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/gpio.h:
https://review.coreboot.org/c/coreboot/+/39427/13/src/mainboard/ocp/tiogapas... PS13, Line 580: TODO
Can that be removed?
Oh sure thanks