Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40487 )
Change subject: mb/google/deltaur: Update H1 I2C gpio pin setting
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40487/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40487/1//COMMIT_MSG@11
PS1, Line 11: BUG=b:150165131
Tested how?
Sorry Paul, sometimes I forget that the context in my head is already there 😊
The board isn't booting yet, this was just an oversight from the schematic review. Eric, would you mind adding something to the commit msg saying we're correcting a mistake from the original GPIO CL?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40487
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43c18baea66b927d51689579a40a53f72b94ef36
Gerrit-Change-Number: 40487
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Apr 2020 21:05:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment