Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45138 )
Change subject: arch/x86/smbios: Update SMBIOS type 0 ec version
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45138/6/src/drivers/ipmi/ipmi_kcs_o...
File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/45138/6/src/drivers/ipmi/ipmi_kcs_o...
PS6, Line 32: static u8 bmc_revision_minor = 0x0;
split ipmi change from ec version change
Done. Split it into CB:46070.
https://review.coreboot.org/c/coreboot/+/45138/6/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/45138/6/src/mainboard/ocp/deltalake...
PS6, Line 41:
Make this a separate commit for the mainboard.
Done. Split it into CB:46071
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45138
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd5ee27a1b8fa4e5bc66e359d3b62e052e19e8a2
Gerrit-Change-Number: 45138
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Oct 2020 01:38:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Gerrit-MessageType: comment