Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/30748
to review the following change.
Change subject: cpu/Kconfig: hide CPU_MICROCODE_CBFS_GENERATE if no SUPPORT_CPU_UCODE_IN_CBFS ......................................................................
cpu/Kconfig: hide CPU_MICROCODE_CBFS_GENERATE if no SUPPORT_CPU_UCODE_IN_CBFS
Trying to use CPU_MICROCODE_CBFS_GENERATE microcode update option for a board which does not support it - could lead to not-obvious problems. For example: if someone tries to use this option e.g. for Lenovo G505S which does not belong to CPU_AMD_MODEL_10XXX (f10h-f15h) group of the only AMD boards supporting it, then CB will be built successfully but the microcode blob will occupy 0 size at CBFS, which would result in worse outcome than if CPU_MICROCODE_CBFS_NONE is selected.
So CPU_MICROCODE_CBFS_GENERATE should be hidden for the not-supporting boards.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I5e4654b14a0c14a25bd6aa62c71ed1d51a7aec03 --- M src/cpu/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/30748/1
diff --git a/src/cpu/Kconfig b/src/cpu/Kconfig index a7cb99e..59c8e23 100644 --- a/src/cpu/Kconfig +++ b/src/cpu/Kconfig @@ -92,6 +92,7 @@
config CPU_MICROCODE_CBFS_GENERATE bool "Generate from tree" + depends on SUPPORT_CPU_UCODE_IN_CBFS help Select this option if you want microcode updates to be assembled when building coreboot and included in the final image as a separate CBFS