Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63126 )
Change subject: Documentation: gpio: Update table as per coreboot guidelines
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
column 3, lines 212 and following
How about replacing `-` with `NA`?
+------------------------+----------------+-------------+-------------+
| | 11 - Resume Reset | Warm Reset | NA | N |
| | (GPP: Reserved, +----------------+-------------+-------------+
| | GPD: RSMRST) | Cold Reset | NA | N |
| +----------------+-------------+-------------+
| | S3/S4/S5 | NA | N |
| +----------------+-------------+-------------+
| | Global Reset | NA | N |
| +----------------+-------------+-------------+
| | Deep Sx | NA | Y |
| +----------------+-------------+-------------+
| | G3 | NA | Y |
+------------------------+----------------+-------------+-------------+
Submitted CL here: CB:63177
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63126
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4f27f46a9d219098612d8b7747ae26116506fce
Gerrit-Change-Number: 63126
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Tue, 29 Mar 2022 18:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment