Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31019
to review the following change.
Change subject: spi/winbond.c: change protection_granularity_shift for W25Q256* from 16 to 19 ......................................................................
spi/winbond.c: change protection_granularity_shift for W25Q256* from 16 to 19
Following the logic of W25Q32*=16 / W25Q64*=17 / W25Q128*=18 , protection_granularity_shift value for W25Q256* chips should be 19.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I488d20898fccd1e967334fdd982b31eedf48f412 --- M src/drivers/spi/winbond.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/31019/1
diff --git a/src/drivers/spi/winbond.c b/src/drivers/spi/winbond.c index 8bf8fcd..9cfa41a 100644 --- a/src/drivers/spi/winbond.c +++ b/src/drivers/spi/winbond.c @@ -264,7 +264,7 @@ .sectors_per_block_shift = 4, .nr_blocks_shift = 9, .name = "W25Q256_V", - .protection_granularity_shift = 16, + .protection_granularity_shift = 19, .bp_bits = 4, }, { @@ -274,7 +274,7 @@ .sectors_per_block_shift = 4, .nr_blocks_shift = 9, .name = "W25Q256J", - .protection_granularity_shift = 16, + .protection_granularity_shift = 19, .bp_bits = 4, }, };