Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48958 )
Change subject: soc/intel/bdw,nb/intel/hsw: convert panel delays to ms representation ......................................................................
Patch Set 9: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/48958/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48958/4//COMMIT_MSG@28 PS4, Line 28: indented tab doesn't work
https://review.coreboot.org/c/coreboot/+/48958/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48958/9//COMMIT_MSG@10 PS9, Line 10: delays `panel delay times`?
https://review.coreboot.org/c/coreboot/+/48958/9/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/chip.h:
https://review.coreboot.org/c/coreboot/+/48958/9/src/northbridge/intel/haswe... PS9, Line 20: u16 gpu_panel_power_cycle_delay_ms; /* T4 time sequence */ use tabs for indentation? or maybe just rip the comments out. there are competing specs with different numbering, so they are only helpful by chance.