Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40322 )
Change subject: soc/amd/picasso: Clean up legacy UART config ......................................................................
Patch Set 3:
(1 comment)
Haha, turns out I forgot to ask what this is used for? is it for software without a memory-mapped UART driver?
https://review.coreboot.org/c/coreboot/+/40322/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/40322/2/src/soc/amd/picasso/Kconfig... PS2, Line 169: uart
fixed the UART comment, but unsure if I should mark Nico's comment as solved
UART_FOR_CONSOLE decides which i/o ports the console writes to (imho, the prompt should be hidden unless there really are multiple i/o port sets decoded on a board, but that's a different story).
I do realize now that UART_FOR_CONSOLE is re-purposed in `picasso/ southbridge.c`. It looks like the console will only work in 4 out of the possible 16 combinations of CONSOLE_FOR_UART and PICASSO_ UART_LEGACY_RANGE. Or do I miss something? How about ditching this Kconfig and using TTYS0_BASE instead? (note, that one is very badly named, it's actually kind of a UART_FOR_CONSOLE_IO_BASE)