HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45574 )
Change subject: nb/intel/haswell: Use common MCHBAR accessor functions ......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45574/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45574/5//COMMIT_MSG@9 PS5, Line 9: baord
board
Done
https://review.coreboot.org/c/coreboot/+/45574/5//COMMIT_MSG@9 PS5, Line 9: remained
I don't think this should be past tense. I generally write this as: […]
Done
https://review.coreboot.org/c/coreboot/+/45574/5/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/45574/5/src/northbridge/intel/haswe... PS5, Line 31: */
Please don't fuse these comments together. […]
Done