[coreboot-gerrit] Change in coreboot[master]: soc/intel/alderlake: remove tmp bar assignment for cpu crashlog

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59355 )

Change subject: soc/intel/alderlake: remove tmp bar assignment for cpu crashlog
......................................................................

soc/intel/alderlake: remove tmp bar assignment for cpu crashlog

When the cpu_cl_discovery is called, coreboot actually assigns a BAR
to cpu crashlog pci device. Hence, we don't need to assign a tmp BAR
for cpu crashlog pci device

BUG=b:195327879
TEST=Found BERT table is created and the tcss function is ok in depthcharge

Change-Id: Ib7e6772be51ec4f26ef31fed6cb2bddef8ffc6be
Signed-off-by: Kane Chen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59355
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
Reviewed-by: Tim Wawrzynczak 
---
M src/soc/intel/alderlake/crashlog.c
1 file changed, 2 insertions(+), 15 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/soc/intel/alderlake/crashlog.c b/src/soc/intel/alderlake/crashlog.c
index 9435aa0..3a857c1 100644
--- a/src/soc/intel/alderlake/crashlog.c
+++ b/src/soc/intel/alderlake/crashlog.c
@@ -210,27 +210,14 @@

m_cpu_crashLog_support = true;

-	/* Program BAR address and enable command register memory space decoding */
-	u32 tmp_bar_addr = PCH_PWRM_BASE_ADDRESS;
-	printk(BIOS_DEBUG, "tmp_bar_addr: 0x%X\n", tmp_bar_addr);
-
-	if (cpu_cl_devsc_cap.discovery_data.fields.t_bir_q == TEL_DVSEC_TBIR_BAR0) {
-		pci_write_config32(SA_DEV_TMT, PCI_BASE_ADDRESS_0, tmp_bar_addr);
-	} else if (cpu_cl_devsc_cap.discovery_data.fields.t_bir_q == TEL_DVSEC_TBIR_BAR1) {
-		pci_write_config32(SA_DEV_TMT, PCI_BASE_ADDRESS_1, tmp_bar_addr);
-	} else {
-		printk(BIOS_DEBUG, "invalid discovery data t_bir_q: 0x%x\n",
-			cpu_cl_devsc_cap.discovery_data.fields.t_bir_q);
-		return false;
-	}
-	pci_or_config16(SA_DEV_TMT, PCI_COMMAND, PCI_COMMAND_MEMORY);
+	const struct resource *res = find_resource(SA_DEV_TMT, PCI_BASE_ADDRESS_0);
+	printk(BIOS_DEBUG, "cpu crashlog bar addr: 0x%llX\n", res->base);

if (!cpu_cl_gen_discovery_table()) {
    	printk(BIOS_ERR, "CPU crashlog discovery table not valid.\n");
    	m_cpu_crashLog_present = false;
    	return false;
    }
-	m_cpu_crashLog_present = true;

return true;
 }