Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )
Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34433/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34433/15//COMMIT_MSG@7 PS15, Line 7: Support get current DRAM ty Add new config for EMCP
https://review.coreboot.org/c/coreboot/+/34433/15//COMMIT_MSG@8 PS15, Line 8: : Get the DRAM type of current platform from build config. : For EMCP DDR, the max supported DRAM frequency is 3600Mbps, : but for DISCRETE DDR, the max supported DRAM frequency is 3200Mbps. : So for different DDR type, need to do different DDR init flow. Devices using eMCP may run in a higher DRAM frequency (e.g., 3600Mbps) while discrete DRAM can only run 3200Mbps.
A new Kconfig is introduced so mainboard can select right config to indicate if the board supports eMCP or not.
https://review.coreboot.org/c/coreboot/+/34433/15/src/soc/mediatek/mt8183/Kc... File src/soc/mediatek/mt8183/Kconfig:
https://review.coreboot.org/c/coreboot/+/34433/15/src/soc/mediatek/mt8183/Kc... PS15, Line 26: bool "EMCP platform should select this config" we should not allow setting this from menu. Please change to def_bool n
and move the "EMCP" into help section.