Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37401 )
Change subject: mb/*/*: use ACPIMMIO common block wherever possible
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37401/1/src/mainboard/amd/lamar/rom...
File src/mainboard/amd/lamar/romstage.c:
https://review.coreboot.org/c/coreboot/+/37401/1/src/mainboard/amd/lamar/rom...
PS1, Line 46: pm_io_write8(0x24, 1);
acpimmio_decode_enable needs differentiating for SB800 and Hudson
Comments elsewher say this platform would be using PMx04 not PMx24.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37401
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I648167ec94367c9494c4253bec21dab20ad7b615
Gerrit-Change-Number: 37401
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 02 Dec 2019 09:42:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment