Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49979 )
Change subject: cpu/x86/smm: Solve lint-007-checkpatch issues ......................................................................
cpu/x86/smm: Solve lint-007-checkpatch issues
lint-007-checkpatch reports warning LONG_LINE and error FUNCTION_WITHOUT_ARGS.
Reducing lines to 96 max. Add void argument to __weak functions.
BUG = N/A TEST = Build Supermicro X11SSH-TF
Change-Id: I1231e52fce1442eb1a966c103dd7f2266e5e209b Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/cpu/x86/smm/smm_module_handler.c 1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/49979/1
diff --git a/src/cpu/x86/smm/smm_module_handler.c b/src/cpu/x86/smm/smm_module_handler.c index 8532d59..e7815f2 100644 --- a/src/cpu/x86/smm/smm_module_handler.c +++ b/src/cpu/x86/smm/smm_module_handler.c @@ -108,7 +108,8 @@ { const uintptr_t save_state = (uintptr_t)(smm_get_save_state(0));
- return *(uint32_t *)(save_state + smm_runtime->save_state_size - SMM_REVISION_OFFSET_FROM_TOP); + return *(uint32_t *)(save_state + smm_runtime->save_state_size - + SMM_REVISION_OFFSET_FROM_TOP); }
bool smm_region_overlaps_handler(const struct region *r) @@ -203,8 +204,8 @@ * are linked at. */ int __weak mainboard_io_trap_handler(int smif) { return 0; } void __weak cpu_smi_handler(void) {} -void __weak northbridge_smi_handler() {} -void __weak southbridge_smi_handler() {} +void __weak northbridge_smi_handler(void) {} +void __weak southbridge_smi_handler(void) {} void __weak mainboard_smi_gpi(u32 gpi_sts) {} int __weak mainboard_smi_apmc(u8 data) { return 0; } void __weak mainboard_smi_sleep(u8 slp_typ) {}