Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39723 )
Change subject: nb/intel/sandybridge: Rewrite table accessors
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39723/6/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit_ivy.c:
https://review.coreboot.org/c/coreboot/+/39723/6/src/northbridge/intel/sandy...
PS6, Line 437: FRQ
we generally have some lower case letter in variables to distinguish them from macros/defines.
This is to be consistent with line 15 of this file. In any case, it gets replaced by a struct field in a later change
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39723
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd7c119b2aa291e6396e12fb29effaf3ec73108a
Gerrit-Change-Number: 39723
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Mar 2020 11:10:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment