[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Add weak function definitions to get ioapic IDs

[Jason Glenesk (Code Review)]

Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46326 )

Change subject: soc/amd/common: Add weak function definitions to get ioapic IDs
......................................................................

Patch Set 3:

(4 comments)

https://review.coreboot.org/c/coreboot/+/46326/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46326/1//COMMIT_MSG@8 
PS1, Line 8:
> The helper function helps with the common code, that will not use the program specific Kconfig. […]

marking resolved

https://review.coreboot.org/c/coreboot/+/46326/1//COMMIT_MSG@10 
PS1, Line 10: overriddden
> Done.

Done

https://review.coreboot.org/c/coreboot/+/46326/1//COMMIT_MSG@15 
PS1, Line 15: MADT.
> In my test image, i set the Kconfig used in the strong override to something other than the hardcode […]

marking resolved

https://review.coreboot.org/c/coreboot/+/46326/1/src/soc/amd/common/block/cp... 
File src/soc/amd/common/block/cpu/cpu.c:

https://review.coreboot.org/c/coreboot/+/46326/1/src/soc/amd/common/block/cp... 
PS1, Line 6: soc_get_fch_ioapic_id
> It feels like this one goes under common/block/smbus instead of here.

moved it