Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33806 )
Change subject: device/oprom: Update vbe_info_t as per vbe specification 3.0
......................................................................
Patch Set 2:
(1 comment)
I don't see why this change is needed.
https://review.coreboot.org/c/coreboot/+/33806/2/src/device/oprom/yabel/vbe....
File src/device/oprom/yabel/vbe.c:
https://review.coreboot.org/c/coreboot/+/33806/2/src/device/oprom/yabel/vbe....
PS2, Line 143:
I see you are deferring this conversion to vbe_get_info() below. But why?
It seems the original code did all conversions here in a common place,
using `vbe_info_t` as an interface to later steps that won't require any
conversion. Please maintain such coherences.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33806
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12db01280aec480f1f42332ebe97d92539dfdc1c
Gerrit-Change-Number: 33806
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 07 Jul 2019 12:29:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment