Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47049 )
Change subject: mb/google/volteer: Skip TPM detection except on SPI
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47049/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47049/7//COMMIT_MSG@19
PS7, Line 19: can be made to support
: longer interrupts
Yes, by default, Dauntless will guarantee 100us interrupt pulse width and spacing. […]
But what about when the next SoC generation comes out and has totally different requirements? If we're redesigning things, couldn't be allow for a programmable-length IRQ pulse? What about other platforms like AMD & ARM? I'm sure their controllers have different requirements.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47049
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08a533cede30a3c0ab943938961dc7e4b572d4ce
Gerrit-Change-Number: 47049
Gerrit-PatchSet: 7
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Nov 2020 19:31:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jes Klinke
jbk@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment