[coreboot-gerrit] Change in ...coreboot[master]: intel/apollolake: Add parameter to enable VTD in devicetree

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31194 )

Change subject: intel/apollolake: Add parameter to enable VTD in devicetree
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/31194/1/src/soc/intel/apollolake/chip.h 
File src/soc/intel/apollolake/chip.h:

https://review.coreboot.org/#/c/31194/1/src/soc/intel/apollolake/chip.h@196 
PS1, Line 196: 	uint8_t enable_vtd;
Newer platforms have a vtd_disable. Maybe normalize on that?

https://review.coreboot.org/#/c/31194/1/src/soc/intel/apollolake/chip.c 
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/31194/1/src/soc/intel/apollolake/chip.c@756 
PS1, Line 756: 	silconfig->VtdEnable = cfg->enable_vtd;
This might affect all APL/GLK boards. Before this change, `VtdEnable`
was set by the FSP binary, after, by the (absence of the) devicetree
setting.