Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38650 )
Change subject: lenovo/t440p: fix keyboard backlight
......................................................................
Patch Set 2: -Code-Review
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2: Code-Review-1
cmos default still says it's defaulting to "Both".
What do you mean?
The file src/mainboard/lenovo/t440p/cmos.default contains "backlight=Both"
Does it?
https://review.coreboot.org/c/coreboot/+/38650/2/src/mainboard/lenovo/t440p/...
Sorry, maybe I downloaded by accident the v1 of the change via git review.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38650
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4c2b1591d26e2bb33f9549e3933efe9a6e0b043
Gerrit-Change-Number: 38650
Gerrit-PatchSet: 2
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dennis Witzig
dennis@wtzg.de
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Feb 2020 04:01:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment