Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32262 )
Change subject: vboot: refactor OPROM code ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/32262/4/src/security/vboot/misc.h File src/security/vboot/misc.h:
https://review.coreboot.org/#/c/32262/4/src/security/vboot/misc.h@40 PS4, Line 40: uint32_t buffer_size;
You're talking about buffer_offset and buffer_size? I'm not so sure what you mean by "so the whole […]
Yes. Also, I'm a moron. buffer_offset may need to be larger than 64K. Don't listen to me. (I guess we could make the flags u16 and the size u16 and then squeeze it together so that it fits, but maybe it's not worth it.)
Right now, as written, this struct is 20 bytes long. vboot_init_work_context sets the workbuf to ALIGN_UP(sizeof(*wd), 16), so that would be 32 with this and you're wasting 28 bytes. No big deal.
https://review.coreboot.org/#/c/32262/4/src/security/vboot/misc.h@47 PS4, Line 47: #define VBOOT_FLAG_DISPLAY_REQUESTED (1 << 0)
Sure. […]
Sounds good.