Attention is currently required from: Patrick Rudolph, Tim Chu.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48640 )
Change subject: soc/intel/xeon_sp/cpx: Override SMBIOS type 4 max speed
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/soc/intel/xeon_sp/cpx/ramstage.c:
https://review.coreboot.org/c/coreboot/+/48640/comment/ea1b5726_949cd456
PS4, Line 13: 3900
This is the max non-turbo ratio, right? Should we read it from a MSR, or is this the maximum non-turbo ratio that CPX processors can have?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67edf657a2fe66b38e08056d558e1b360c4b8adc
Gerrit-Change-Number: 48640
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 04 Feb 2021 09:52:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment