Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40579 )
Change subject: vboot: Add permission check for kernel space ......................................................................
Patch Set 8:
(6 comments)
https://review.coreboot.org/c/coreboot/+/40579/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40579/6//COMMIT_MSG@13 PS6, Line 13: Signed-off-by: dnojiri dnojiri@chromium.org
Please use you full name and move the SoB line right below the Change-Id line.
Done
https://review.coreboot.org/c/coreboot/+/40579/5/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/40579/5/src/security/tpm/tss.h@203 PS5, Line 203: uint32_t tlcl_get_permissions(uint32_t index, uint32_t* permissions);
"foo* bar" should be "foo *bar"
Done
https://review.coreboot.org/c/coreboot/+/40579/5/src/security/tpm/tss/tcg-1.... File src/security/tpm/tss/tcg-1.2/tss.c:
https://review.coreboot.org/c/coreboot/+/40579/5/src/security/tpm/tss/tcg-1.... PS5, Line 363: uint32_t tlcl_get_permissions(uint32_t index, uint32_t* permissions)
"foo* bar" should be "foo *bar"
Done
https://review.coreboot.org/c/coreboot/+/40579/5/src/security/tpm/tss/tcg-1.... PS5, Line 367: uint8_t* nvdata;
"foo* bar" should be "foo *bar"
Done
https://review.coreboot.org/c/coreboot/+/40579/3/src/security/vboot/secdata_... File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/40579/3/src/security/vboot/secdata_... PS3, Line 72: #if !CONFIG(TPM2)
That requires TPM_NV_PER_PPWRITE to be defined for TPM2 as well. […]
Done
https://review.coreboot.org/c/coreboot/+/40579/6/src/security/vboot/secdata_... File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/40579/6/src/security/vboot/secdata_... PS6, Line 86: "TPM: invalid secdata_kernel permissions\n");
I don't think it does? As long as files aren't globally adjusted to 96 characters, we should stick t […]
Ack