HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25601 )
Change subject: nb/intel/x4x: Use parallel MP init
......................................................................
Patch Set 36:
(2 comments)
https://review.coreboot.org/#/c/25601/36/src/cpu/intel/model_f4x/model_f4x_i...
File src/cpu/intel/model_f4x/model_f4x_init.c:
https://review.coreboot.org/#/c/25601/36/src/cpu/intel/model_f4x/model_f4x_i...
PS36, Line 16: #include <cpu/x86/mtrr.h>
Maybe you can remove this if it is not used
https://review.coreboot.org/#/c/25601/36/src/cpu/intel/model_f4x/model_f4x_i...
PS36, Line 18: #include <cpu/intel/microcode.h>
: #include <cpu/intel/hyperthreading.h>
remove ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25601
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5a2729f5bf6b525abad577e63d7953ae6640921
Gerrit-Change-Number: 25601
Gerrit-PatchSet: 36
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 12 Jan 2019 08:46:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment