Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40223 )
Change subject: mb/google/hatch: Add Duffy variant ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40223/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/duffy/gpio.c:
PS1:
Please use SPDX: […]
Done
https://review.coreboot.org/c/coreboot/+/40223/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/duffy/mainboard.c:
https://review.coreboot.org/c/coreboot/+/40223/1/src/mainboard/google/hatch/... PS1, Line 50: gpio_configure_pads. */
nit: this line and the first `if` fit in one line
this is a copy of variants/puff so I am keeping the source the same for now.
https://review.coreboot.org/c/coreboot/+/40223/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/duffy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40223/1/src/mainboard/google/hatch/... PS1, Line 295: # VR Settings Configuration for 4 Domains
I think vr_config. […]
this is a copy of variants/puff so I am keeping the source the same for now.