Hello Jason Glenesk, build bot (Jenkins), Martin Roth, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46854
to look at the new patch set (#2).
Change subject: soc/amd/picasso: Fix the PSP SMI trigger info ......................................................................
soc/amd/picasso: Fix the PSP SMI trigger info
Align coreboot's PSP MboxBiosCmdSmmInfo setup to how AGESA's PSP library was implemented. The trigger address must be an SMI trigger register. Assign one of the reserved triggers to the PSP.
The #define of SMITYPE_PSP 33 is still correct and is intentionally unmodified.
This patch should be innocuous as the system doesn't currently support SMI-based features of the PSP. The call only exists so the PSP will honor a mailbox command during S3 suspend.
BUG=b:171815390 TEST=Run SST on Morphius BRANCH=Zork
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I74029271a522a4f23e54fd76f99a8e3eb0dd4d55 --- M src/soc/amd/picasso/include/soc/smi.h M src/soc/amd/picasso/psp.c 2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/46854/2