Attention is currently required from: Joel Bueno, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change by Joel Bueno. ( https://review.coreboot.org/c/coreboot/+/85800?usp=email )
Change subject: commonlib/device_tree: fix 64-bit misaligned member access
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I don't think we should make changes to architecture-independent code to support the quirks of a sin […]
You are right. This issue has come up before and will likely do so again. I am trying to avoid the misaligned exception handler because it adds a hefty overhead. But I agree that it doesn't make sense to impose that limitation onto all the other architectures.
But I don't understand how be64dec can use RISC-V specific implementations? I was under the impression that the decode functions are all common code only? As far as I know only the MMIO read/write functions are architecture code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85800?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I567103bcd956b10fab64c5e63018315924ec0d2b
Gerrit-Change-Number: 85800
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Bueno
joel.bueno@openchip.com
Gerrit-Reviewer: Carlos López
carlos.lopezr4096@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Joel Bueno
joel.bueno@openchip.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 26 Feb 2025 00:34:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org