Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/44786 ) Change subject: gma registers: Allow to specify an offset for display registers ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/libgfxinit/+/44786/3/common/hw-gfx-gma-registe... File common/hw-gfx-gma-registers.adb: https://review.coreboot.org/c/libgfxinit/+/44786/3/common/hw-gfx-gma-registe... PS3, Line 214: return Reg'Enum_Rep + Config.Display_Base_Offset / Register_Width;
For now, I would just double check the log against one from before you […] It works, and I found several bugs regarding handling of DPIO and other stuff, so it's not really comparable. Plus, the register names often do not match, which is annoying.
-- To view, visit https://review.coreboot.org/c/libgfxinit/+/44786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Id5497a23776e9aa9e2fd5ca0479030cb8e55712f Gerrit-Change-Number: 44786 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 30 Aug 2020 12:54:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment