[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x/dq_dqs.c: Avoid breaking strings over multiple lines

[Angel Pons (Code Review)]

Attention is currently required from: Damien Zammit, Patrick Rudolph.
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51876 )

Change subject: nb/intel/x4x/dq_dqs.c: Avoid breaking strings over multiple lines
......................................................................

nb/intel/x4x/dq_dqs.c: Avoid breaking strings over multiple lines

Breaking strings across multiple lines hurts greppability. Refactor the
code a bit to drop one indentation level, and then reflow the strings.

Change-Id: I0accdfd0d2c5f58e4da493ba0d4b5c6a067d92c3
Signed-off-by: Angel Pons 
---
M src/northbridge/intel/x4x/dq_dqs.c
1 file changed, 11 insertions(+), 17 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/51876/1

diff --git a/src/northbridge/intel/x4x/dq_dqs.c b/src/northbridge/intel/x4x/dq_dqs.c
index afb7742..6045f3b 100644
--- a/src/northbridge/intel/x4x/dq_dqs.c
+++ b/src/northbridge/intel/x4x/dq_dqs.c
@@ -656,16 +656,13 @@
    			lane,
    			dq_sample[lane]);

-			if (dq_sample[lane] > 0) {
-				if (decrement_dq_dqs(s, &dqs_setting[lane])) {
-					printk(BIOS_EMERG,
-						"DQS setting channel%d, "
-						"lane %d reached a minimum!\n",
-						channel, lane);
-					return CB_ERR;
-				}
-			} else {
+			if (dq_sample[lane] == 0) {
    			bytelane_ok |= (1 << lane);
+			} else if (decrement_dq_dqs(s, &dqs_setting[lane])) {
+				printk(BIOS_EMERG,
+					"DQS setting channel%d, lane %d reached a minimum!\n",
+					channel, lane);
+				return CB_ERR;
    		}
    		dqsset(channel, lane, &dqs_setting[lane]);
    	}
@@ -695,14 +692,11 @@

if (dq_sample[lane] == N_SAMPLES) {
    			bytelane_ok |= (1 << lane);
-			} else {
-				if (increment_dq_dqs(s, &dqs_setting[lane])) {
-					printk(BIOS_EMERG,
-						"DQS setting channel%d, "
-						"lane %d reached a maximum!\n",
-						channel, lane);
-					return CB_ERR;
-				}
+			} else if (increment_dq_dqs(s, &dqs_setting[lane])) {
+				printk(BIOS_EMERG,
+					"DQS setting channel%d, lane %d reached a maximum!\n",
+					channel, lane);
+				return CB_ERR;
    		}
    		dqsset(channel, lane, &dqs_setting[lane]);
    	}