Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39801 )
Change subject: [WIP]TGL: Make the GPIO asl table in sync with kernel ......................................................................
Patch Set 2:
(4 comments)
Patch Set 2:
Patch Set 2:
Still waiting for the results to come back from the OS team.
What's the latest here? Who on the OS team is supposed to provide the results? Can you please post updates on the bug?
Chintan's team is working on testing those. Also I made some local changes based on Aamir's chnage where they have 2 asl files(for tgl and jsl). but their recent version they seems to have back to 1 single file. So i am readjusting those change and checking on my side again. Will push the final change from cb side by tomorrow.
https://review.coreboot.org/c/coreboot/+/39801/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39801/2//COMMIT_MSG@7 PS2, Line 7: [WIP]TGL: Make the GPIO asl table in sync with kernel
Maybe: […]
Ack
https://review.coreboot.org/c/coreboot/+/39801/2//COMMIT_MSG@9 PS2, Line 9: lake
Lake
Ack
https://review.coreboot.org/c/coreboot/+/39801/2/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39801/2/src/soc/intel/tigerlake/acp... PS2, Line 20: #if CONFIG(SOC_INTEL_TIGERLAKE)
There are some changes happening for JSL GPIO as well here: CB:39470 […]
Ack
https://review.coreboot.org/c/coreboot/+/39801/2/src/soc/intel/tigerlake/acp... PS2, Line 20: #if CONFIG(SOC_INTEL_TIGERLAKE)
This is not mentioned in the commit message.
Ack