Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31372 )
Change subject: soc/amd: Add support to soc merlinfalcon ......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
https://review.coreboot.org/#/c/31372/2/src/soc/amd/stoneyridge/Kconfig File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/#/c/31372/2/src/soc/amd/stoneyridge/Kconfig@30 PS2, Line 30: For SOC MerlinFalcon, select SOC_AMD_STONEYRIDGE_FP4 and : STONEYRIDGE_CPU_MF as the only difference between StoneyRidge : and MerlinFalcon is the internal CPU, and therefore the video : (3rdparty/blobs/soc/amd/merlinfalcon) and AGESA.
I think you missed what I was suggesting. Change this whole thing to be: […]
I understood perfectly. I just said it's no longer needed when I define SOC_AMD_MERLINFALCON_FP4 due to the changes in Kconfig that this definition entitles.